[PATCH] D148549: ValueTracking: Implement computeKnownFPClass for log

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4390
+        computeKnownFPClass(II->getArgOperand(0), DemandedElts,
+                            InterestedClasses, KnownSrc, Depth + 1, Q, TLI);
+
----------------
Blindly propagating InterestedClasses seems wrong again. E.g. if InterestedClasses contains fcNegInf then the value you pass down should contain fcZero.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4395
+
+          if (KnownSrc.cannotBeOrderedLessThanZero())
+            Known.knownNot(fcNan);
----------------
Why is this inside the NeverPosInf check? Doesn't it also need a NeverNan check?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148549/new/

https://reviews.llvm.org/D148549