[PATCH] D148608: [X86] Create all-one vector(v8i32) for TESTC(X,~X) == TESTC(X,-1) if X is v8f32

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 01:51:23 PDT 2023


RKSimon added a comment.

Nice catch



================
Comment at: llvm/test/CodeGen/X86/combine-testp-v8f32.ll:4
+
+define void @test(<8 x i32> %ref.tmp.sroa.0.16.vec.expand.i.i.i.i.i.i.i) #0 personality ptr null {
+; AVX-LABEL: test:
----------------
pengfei wrote:
> Simplify the names.
Please can you put this in combine-testps.ll and an equivalent in combine-testpd.ll - there should be matching tests (and naming convention) with combine-ptest.ll that you can base it off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148608/new/

https://reviews.llvm.org/D148608



More information about the llvm-commits mailing list