[PATCH] D148550: [CodeGen] Add pre-commit tests for handling -Ofast generated code in ComplexDeinterleaving pass

mgabka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 01:42:14 PDT 2023


mgabka added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-add-mull-fixed-contract.ll:6
+
+; a * b + c
+define <4 x double> @mull_add(<4 x double> %a, <4 x double> %b, <4 x double> %c) {
----------------
maybe worth to add a comment explaining why the input IR in this and other files you add here  looks like that?

I also noticed that this file and complex-deinterleaving-add-mull-scalable-contract.ll is not modified in the follow up patch, so maybe worth to explain it in the commit message, why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148550/new/

https://reviews.llvm.org/D148550



More information about the llvm-commits mailing list