[PATCH] D148316: [AArch64] Add support for efficient bitcast in vector truncate store.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1223
+    setTruncStoreAction(MVT::v2i64, MVT::v2i1, Custom);
+    setTruncStoreAction(MVT::v8i8, MVT::v16i1, Custom);
+    setTruncStoreAction(MVT::v4i16, MVT::v4i1, Custom);
----------------
v8i1? It doesn't appear that these are necessary though, as the trunc stores are already created and the new code goes through a combine.

You could alternatively add the call to combineVectorCompareAndTruncateStore to lowerSTORE instead of the combine.


================
Comment at: llvm/test/CodeGen/AArch64/vec_uaddo.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --function uaddo_v4i1
 ; RUN: llc < %s -mtriple=aarch64-none-linux-gnu -mattr=+neon | FileCheck %s --check-prefix=CHECK
----------------
Remove this?


================
Comment at: llvm/test/CodeGen/AArch64/vec_umulo.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --function umulo_v4i1
 ; RUN: llc < %s -mtriple=aarch64-none-linux-gnu -mattr=+neon | FileCheck %s --check-prefix=CHECK
----------------
Remove this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148316/new/

https://reviews.llvm.org/D148316