[PATCH] D148073: [SCEV] Improve willNotOverflow by checking min/max in wide range with context

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 00:17:34 PDT 2023


mkazantsev added inline comments.


================
Comment at: llvm/test/Transforms/IndVarSimplify/strengthen-overflow.ll:307
 ; CHECK-NEXT:    [[PHI:%.*]] = phi i32 [ [[ADD:%.*]], [[BB2:%.*]] ], [ 0, [[BB:%.*]] ]
-; CHECK-NEXT:    [[SUB:%.*]] = sub nsw i32 [[FREEZE]], [[PHI]]
+; CHECK-NEXT:    [[SUB:%.*]] = sub i32 [[FREEZE]], [[PHI]]
 ; CHECK-NEXT:    [[ICMP:%.*]] = icmp sgt i32 [[SUB]], 1
----------------
mkazantsev wrote:
> Regression.
This regression isn't even because the analysis gives a better result. It's simply because we make a query... Weird.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148073/new/

https://reviews.llvm.org/D148073



More information about the llvm-commits mailing list