[PATCH] D148210: [InstCombine] icmp(MulC * X * Y, C) --> icmp(X * Y, C)

[chenglin.bi via Phabricator via llvm-commits]

bcl5980 added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:2056
+
+  if (match(Mul, m_c_Mul(m_BinOp(InnerMul), m_Value(Y))) &&
+      match(InnerMul, m_c_Mul(m_APInt(MulC), m_Value(X)))) {
----------------
bcl5980 wrote:
> It looks we need to limit both `*` to one-use.
At least outer mul need one-use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148210/new/

https://reviews.llvm.org/D148210