[PATCH] D148568: [FuzzMutate] InsertFunctionStrategy

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 16:24:59 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:346
+  // If nullptr is selected, we will create a new function declaration.
+  SmallVector<Function *, 32> Functions({nullptr});
+  for (Function &F : M->functions()) {
----------------
Don't see the point of the initializer here


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:359
+  SmallVector<fuzzerop::SourcePred, 2> SourcePreds;
+  if (F->arg_size() != 0) {
+    for (Type *ArgTy : FTy->params()) {
----------------
arg_empty


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148568/new/

https://reviews.llvm.org/D148568



More information about the llvm-commits mailing list