[PATCH] D148192: [JITLink][ELF][PPC64] Add skeleton ppc64 support and ELF/ppc64 JITLink backend.

[Lang Hames via Phabricator via llvm-commits]

lhames marked an inline comment as done.
lhames added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/ppc64.h:44
+
+} // namespace ppc64
+} // end namespace jitlink
----------------
MaskRay wrote:
> inconsistent "end namespace" marker? :)
> 
> Note: with C++17 we can do `namespace llvm::jitlink::ppc64`
Good point. I've updated the namespaces in the latest version.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF.cpp:79
     return createLinkGraphFromELFObject_loongarch(ObjectBuffer);
+  case ELF::EM_PPC64: {
+    if (DataEncoding == ELF::ELFDATA2LSB)
----------------
MaskRay wrote:
> The braces are optional.
> 
> LLVM style may prefer removing the `else`, so that the number of lines is even smaller.
I tried this without the braces, but it scans oddly when reading (it looks like incorrectly indented cases). I think it's worth keeping them for grouping here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148192/new/

https://reviews.llvm.org/D148192