[PATCH] D148517: [llvm-lib] [llvm-readobj] [llvm-cvtres] Add Support for ARM64X object files.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

It looks like this covers all the basics... the "object file you can treat either way" thing is a bit weird, but I guess that's defined by Microsoft.



================
Comment at: llvm/include/llvm/BinaryFormat/COFF.h:124
 
+template <typename T> bool isArm64EC(T Machine) {
+  return Machine == IMAGE_FILE_MACHINE_ARM64EC ||
----------------
It looks like you don't use this helper anywhere other than this header.


================
Comment at: llvm/include/llvm/BinaryFormat/COFF.h:129
+
+template <typename T> bool isArm64(T Machine) {
+  return Machine == IMAGE_FILE_MACHINE_ARM64 || isArm64EC(Machine);
----------------
Maybe name this isAnyArm64, or something like that, to indicate that it's encompassing all the different variants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148517/new/

https://reviews.llvm.org/D148517