[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table-warning.test:35
+
+# WARN:     {{.*}}: warning: '{{.*}}': The length of the function name must be greater than zero if the isFuncNamePresent is set in the trace backbak table.
----------------
jhenderson wrote:
> Please a) review the error message content and fix it (I'm not going to point it out - it should be obvious to you with a quick look), b) review the LLVM coding standards for formatting of error and warning messages and fix accordingly. If you're still not sure what needs to be changed, please ask, but I don't want to need to explain everything in detail when things should be obvious.
> 
> There's no need for the extra space indentation at the start of the CHECK line, i.e. it should be `# WARN: {{.*}}` etc. Also, there's no real need for the first `{{.*}}: ` before `warning:`. Finally, it would be good to check the actual file name after `warning:`. You can add `-D FILE=%t.o` to the FileCheck invocation and then use `[[FILE]]` in place of the `{{.*}}` for the file path.
sorry for above mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049