[PATCH] D148331: [ARM] Fix t2BF_LabelPseudo.isTerminator

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 12:43:38 PDT 2023


lenary added a comment.

In D148331#4275175 <https://reviews.llvm.org/D148331#4275175>, @dmgreen wrote:

> Either way in the long run it should probably be cleaned up to perhaps be a pair of different pseudos.

There are other solutions that have been added to LLVM, like `preInstrSymbol` and `postInstrSymbol`, which might be more apt now, depending on the intended semantics (though, this should still be right, based on the code that's upstream for how these are emitted. I don't have access to the downstream code any more, so I can no longer verify, and on the same basis, I likely need someone from Arm to commandeer this patch from me anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148331/new/

https://reviews.llvm.org/D148331



More information about the llvm-commits mailing list