[PATCH] D148558: [CodeGen] Improve handling -Ofast generated code by ComplexDeinterleaving pass

[Igor Kirillov via Phabricator via llvm-commits]

igor.kirillov added a comment.

I would like to bring up some questions:

1. What is your opinion on the approach taken to handle -Ofast? While it may seem complicated, it attempts to address a broad range of scenarios and I'm not sure how it could be simplified.
2. Due to the lack of direct link between ComplexDeinterleavingNode and IR Instrucitons when using -Ofast, I decided to use IRBuilder to create all new instructions in ordered way. This code can be extracted into a separate patch.
3. Do we need additional tests? I have already included tests that demonstrate the difference between -Ofast and -O3 -ffp-contract=fast -ffinite-math-only in D148550 <https://reviews.llvm.org/D148550>. However, now we have some redundant tests in other files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148558/new/

https://reviews.llvm.org/D148558