[PATCH] D145208: [COFF] Add MC support for emitting IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY symbols

[Eli Friedman via Phabricator via llvm-commits]

efriedma updated this revision to Diff 514314.
efriedma added a comment.

Address review comments.

After looking at MCSymbol::getFragment() a bit more, I decided it makes more sense to check isWeakExternal() there, instead of in MCExpr::findAssociatedFragment().  End result is sort of similar because getFragment() is the only caller of findAssociatedFragment(), but the semantics make more sense if the recursion stops earlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145208/new/

https://reviews.llvm.org/D145208

Files:
  llvm/include/llvm/MC/MCDirectives.h
  llvm/include/llvm/MC/MCSymbol.h
  llvm/include/llvm/MC/MCSymbolCOFF.h
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCExpr.cpp
  llvm/lib/MC/MCMachOStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/COFFAsmParser.cpp
  llvm/lib/MC/MCWinCOFFStreamer.cpp
  llvm/lib/MC/WinCOFFObjectWriter.cpp
  llvm/test/MC/COFF/addrsig.s
  llvm/test/MC/COFF/alias.s
  llvm/test/MC/COFF/weak-anti-dep.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145208.514314.patch
Type: text/x-patch
Size: 11659 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230417/9342aaf9/attachment-0001.bin>