[PATCH] D148543: [llvm-driver] Check more specific tools first

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 10:20:52 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-driver/llvm-driver.cpp:32
+using ToolEntry = int(int, char **, const llvm::ToolContext &);
+std::map<StringRef, ToolEntry &, std::greater<StringRef>> ToolMap{
+#define LLVM_DRIVER_TOOL(tool, entry) {tool, entry##_main},
----------------
MaskRay wrote:
> This leaves a dynamic initialization. It'd be better to keep LLVMDriverTools.def and reverse iterate `ToolMap`.
I mean "keep LLVMDriverTools.def sorted".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148543/new/

https://reviews.llvm.org/D148543



More information about the llvm-commits mailing list