[PATCH] D145374: [FuncSpec] Consider constant struct arguments when specializing.

[Alexandros Lamprineas via Phabricator via llvm-commits]

labrinea added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:843
+
+void SCCPInstVisitor::handleSpecializationArguments(Function *F,
+                          const SmallVectorImpl<ArgInfo> &Args) {
----------------
chill wrote:
> `handleXXX` is very uninformative, it might be good in a contexts where we don't know
> what kind of "handling" is done by the caller (like e.g. "visit"), but in this specific case
> of setitng up/initialising lattice values for the parameters it's better called just like that, something like
> `initSpecializationParemetersLaticeValues`, `setupSpecArgsValueStates`, etc.
Agree thanks. I was thinking of `SetLatticeValueForSpecializationArguments` but it was a bit long. We already have similar names: `getLatticeValueFor`, `removeLatticeValueFor` and `resetLatticeValueFor` (see D146158).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145374/new/

https://reviews.llvm.org/D145374