[PATCH] D141030: [AMDGPU] Legalize soffset of buffer instruction. Use Waterfall loop logic.
krishna chaitanya sankisa via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 17 09:06:48 PDT 2023
skc7 added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/legalize-soffset-mbuf.ll:34
+ ; CHECK-NEXT: SI_RETURN implicit $vgpr0
+ %val = call float @llvm.amdgcn.raw.buffer.load.f32(<4 x i32> poison, i32 %voffset, i32 %soffset, i32 0)
+ ret float %val
----------------
arsenm wrote:
> All of these tests are using poison for the SRD, these should use a meaningful value
These tests are checking if a waterfall loop is created if only soffset is illegal. So, SRD has been made poison.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141030/new/
https://reviews.llvm.org/D141030
More information about the llvm-commits
mailing list