[PATCH] D146119: [llvm-readobj][AMDGPU] Bypass MD verification for PAL

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 03:42:41 PDT 2023


foad added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5508
+    //  This is an ugly workaround to avoid the verifier.
+    if (MsgPackString.find("amdpal.") == StringRef::npos) {
+      AMDGPU::HSAMD::V3::MetadataVerifier Verifier(true);
----------------
Since this is AMDHSA stuff, could you check for the presence of "amdhsa." instead of the absence of "amdpal."?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146119/new/

https://reviews.llvm.org/D146119



More information about the llvm-commits mailing list