[PATCH] D148065: InstCombine: Directly use computeKnownFPClass in is.fpclass combines

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 02:42:30 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

In D148065#4269885 <https://reviews.llvm.org/D148065#4269885>, @arsenm wrote:

> In D148065#4260951 <https://reviews.llvm.org/D148065#4260951>, @foad wrote:
>
>>> The various isKnownNever* calls can be merged into one.
>>
>> That makes it sounds like an NFC change, but it is clearly improving some tests.
>
> From the passing of the assumption cache. Could split the parts

I think it's fine to commit as-is if you mention this in the commit message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148065/new/

https://reviews.llvm.org/D148065



More information about the llvm-commits mailing list