[PATCH] D146900: [docs][LangRef] Added minor update inside the `frem`. Fix : #61653

Benjamin Chetioui via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 02:13:35 PDT 2023


bchetioui requested changes to this revision.
bchetioui added a comment.
This revision now requires changes to proceed.

Thanks!

I understand now that the intent behind the issue is that one may need to link `libm` in order to use `frem`, which was not obvious to me from the initial change.
I suggested an edit that conveys this more directly. Let me know what you think.



================
Comment at: llvm/docs/LangRef.rst:9586-9589
+its two operands. On some target, such as X86, the instruction is 
+implemented as call to '``libm``' '``fmod``' function, but the 
+output is equivalent to the mathematical remainder.
+
----------------
Thanks for your patience. I propose the following rewrite for your change (or something to that effect). WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146900/new/

https://reviews.llvm.org/D146900



More information about the llvm-commits mailing list