[PATCH] D148306: remove useless condition in assert in SelectionDAG.cpp

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7955
           Opcode == ISD::PREFETCH ||
-          ((int)Opcode <= std::numeric_limits<int>::max() &&
-           (int)Opcode >= ISD::FIRST_TARGET_MEMORY_OPCODE)) &&
+          (int)Opcode >= ISD::FIRST_TARGET_MEMORY_OPCODE) &&
          "Opcode is not a memory-accessing opcode!");
----------------
skan wrote:
> Should we use `Opcode <= (unsigned)std::numeric_limits<int>::max()`?
Yes, it should be the intention of the author.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148306/new/

https://reviews.llvm.org/D148306