[PATCH] D148002: Fix mem leak in WindowsManifestMerger.cpp

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:352
+        if (NewDefinedDefaultHref)
+          xmlFree(const_cast<unsigned char *>(NewDefinedDefaultHref));
         return make_error<WindowsManifestError>(
----------------
Do we need to free the memory when the error is taken?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148002/new/

https://reviews.llvm.org/D148002