[PATCH] D148305: remove useless call in MIRSampleProfile.cpp

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:277
   ProfileIsValid = (Reader->read() == sampleprof_error::success);
-  Reader->getSummary();
 
----------------
skan wrote:
> I'm afraid we can not remove it b/c `getSummary` may change the internal state of `Reader`.
This will just call unique_ptr::get() to return a ptr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148305/new/

https://reviews.llvm.org/D148305