[PATCH] D147866: ValueTracking: Implement computeKnownFPClass for minnum/maxnum

Sun Apr 16 07:57:45 PDT 2023

arsenm added a comment.

In D147866#4269440 <https://reviews.llvm.org/D147866#4269440>, @jcranmer-intel wrote:

> In D147866#4269363 <https://reviews.llvm.org/D147866#4269363>, @arsenm wrote:
>
>> In D147866#4269348 <https://reviews.llvm.org/D147866#4269348>, @jcranmer-intel wrote:
>>
>>> `minnum(0.0, 0.0)` can return `-0.0`, so the handling around positive/negative zero isn't correct.

The sign is of zero is not indeterminate. minnum(0.0, 0.0) cannot choose to introduce a signed zero. The ordering of a positive zero and negative zero is undetermined.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147866/new/

https://reviews.llvm.org/D147866