[PATCH] D148420: [InstCombine] Enhance select icmp and folding

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

As this does not create a new instruction, it should be part of InstSimplify (probably in simplifySelectWithICmpCond).



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:239
+  if (Sel.getType()->isVectorTy() || Cmp->getType()->isVectorTy())
+    return nullptr;
+
----------------
Why exclude vectors? Looks like they should work out of the box?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148420/new/

https://reviews.llvm.org/D148420