[PATCH] D148129: [GVN] Adjust metadata for coerced load CSE

[luxufan via Phabricator via llvm-commits]

StephenFan accepted this revision.
StephenFan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1008
+      // unless the load has !noundef, in which case all metadata violations
+      // will be promoted to UB.
+      if (!CoercedLoad->hasMetadata(LLVMContext::MD_noundef))
----------------
For !noalias or !alias.scope, I think we don't care about the size and type. But it is also dropped. Maybe leave a TODO which says we can do better for these two metadata.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148129/new/

https://reviews.llvm.org/D148129