[PATCH] D148445: [libunwind] Remove the legacy Unwind_AppleExtras.cpp

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 15 16:41:34 PDT 2023


ldionne created this revision.
Herald added projects: libunwind, All.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libunwind.
ldionne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Unwind_AppleExtras.cpp contained annotations telling the linker that
some symbols are not available on some very old platforms. However,
those platforms are not supported anymore, so the annotations are not
used.

Why remove this? In addition to cleaning up the code base, this also
removes the possibility of implementing those annotations incorrectly
(which was the case previously), which could lead to important symbols
being hidden when they should have been visible.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148445

Files:
  libunwind/src/CMakeLists.txt
  libunwind/src/Unwind_AppleExtras.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148445.513948.patch
Type: text/x-patch
Size: 5751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230415/7bb0bd49/attachment.bin>


More information about the llvm-commits mailing list