[PATCH] D148442: [compiler-rt] [test] Don't override config.unsupported in TestCases/Windows
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 15 15:06:52 PDT 2023
mstorsjo created this revision.
mstorsjo added reviewers: vitalybuka, alvinhochun.
Herald added subscribers: Enna1, dberris.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.
This is a leftover from when these tests were added in
2bdca2006941a3a7de8e16ea9af9a758b367ee32 in 2014 (when the toplevel
asan/lit.cfg set "config.unsupported = True" on Windows). When the
common tests were included on Windows in
89d994367a597134fa7e1724314044e217718165 in 2015, that commit should
have removed the now unnecessary "config.unsupported = False" line here.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D148442
Files:
compiler-rt/test/asan/TestCases/Windows/lit.local.cfg.py
Index: compiler-rt/test/asan/TestCases/Windows/lit.local.cfg.py
===================================================================
--- compiler-rt/test/asan/TestCases/Windows/lit.local.cfg.py
+++ compiler-rt/test/asan/TestCases/Windows/lit.local.cfg.py
@@ -5,10 +5,5 @@
root = getRoot(config)
-# We only run a small set of tests on Windows for now.
-# Override the parent directory's "unsupported" decision until we can handle
-# all of its tests.
-if root.host_os in ['Windows']:
- config.unsupported = False
-else:
+if root.host_os not in ['Windows']:
config.unsupported = True
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148442.513942.patch
Type: text/x-patch
Size: 590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230415/2ad0da02/attachment.bin>
More information about the llvm-commits
mailing list