[llvm] 38d84e3 - [GISel] Legalize G_FSUB to G_FADD + G_FNEG even if G_FNEG is illegal

[Sergei Barannikov via llvm-commits]

Author: Sergei Barannikov
Date: 2023-04-15T08:11:49+03:00
New Revision: 38d84e3d76fb161b8cfbaad7644fb72b20c6c433

URL: https://github.com/llvm/llvm-project/commit/38d84e3d76fb161b8cfbaad7644fb72b20c6c433
DIFF: https://github.com/llvm/llvm-project/commit/38d84e3d76fb161b8cfbaad7644fb72b20c6c433.diff

LOG: [GISel] Legalize G_FSUB to G_FADD + G_FNEG even if G_FNEG is illegal

`G_FNEG` used to be legalized to `G_FSUB -0, x` causing infinite loop.
This is no longer the case after D84287.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D148187

Added: 
    

Modified: 
    llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index feb355f6c551c..c61ed539a543a 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -3333,10 +3333,6 @@ LegalizerHelper::lower(MachineInstr &MI, unsigned TypeIdx, LLT LowerHintTy) {
     LLT Ty = MRI.getType(Res);
 
     // Lower (G_FSUB LHS, RHS) to (G_FADD LHS, (G_FNEG RHS)).
-    // First, check if G_FNEG is marked as Lower. If so, we may
-    // end up with an infinite loop as G_FSUB is used to legalize G_FNEG.
-    if (LI.getAction({G_FNEG, {Ty}}).Action == Lower)
-      return UnableToLegalize;
     auto Neg = MIRBuilder.buildFNeg(Ty, RHS);
 
     if (MI.getOpcode() == TargetOpcode::G_STRICT_FSUB)