[PATCH] D148304: [LoongArch] Use empty debug location for register spill/reload
WÁNG Xuěruì via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 21:58:05 PDT 2023
xen0n accepted this revision.
xen0n added a comment.
This revision is now accepted and ready to land.
In D148304#4270645 <https://reviews.llvm.org/D148304#4270645>, @benshi001 wrote:
> We can see a `.loc` is eliminated by my patch. It is not good to test my patch with `CHECK-NOT: .loc ***`. We have to commit the test in another patch and then we can see the difference. But is it worthy to do so? This is just a tiny change.
Fine with me then, it's not one of those non-trivial changes that would benefit very much from test coverage anyway. I said "if feasible" in my original comment too ;-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148304/new/
https://reviews.llvm.org/D148304
More information about the llvm-commits
mailing list