[PATCH] D143463: [X86] Use the CFA as the DWARF frame base for better variable locations around calls.

Kyle Huey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 15:06:25 PDT 2023


khuey updated this revision to Diff 513760.
khuey retitled this revision from "[X86] Use the CFA when appropriate for better variable locations around calls." to "[X86] Use the CFA as the DWARF frame base for better variable locations around calls.".
khuey edited the summary of this revision.
khuey added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: jhenderson.
Herald added a subscriber: cmtice.

Use the CFA as the DWARF frame base whenever it's present.

As discussed, this drops the previous heuristic for determining
when we need to use the CFA for accurate results and simply uses
the CFA in all cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143463/new/

https://reviews.llvm.org/D143463

Files:
  llvm/include/llvm/CodeGen/TargetFrameLowering.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/Target/X86/X86FrameLowering.cpp
  llvm/lib/Target/X86/X86FrameLowering.h
  llvm/test/CodeGen/X86/dbg-baseptr.ll
  llvm/test/DebugInfo/X86/dwarf-public-names.ll
  llvm/test/ExecutionEngine/OrcLazy/debug-objects-elf-minimal.ll
  llvm/test/MC/X86/dwarf-size-field-overflow.test
  llvm/test/tools/llvm-dwarfdump/X86/statistics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143463.513760.patch
Type: text/x-patch
Size: 9215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230414/93b269fb/attachment.bin>


More information about the llvm-commits mailing list