[PATCH] D142318: [Support] Add PerThreadBumpPtrAllocator class.
Alexey Lapshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 13:43:16 PDT 2023
avl added a comment.
In D142318#4269072 <https://reviews.llvm.org/D142318#4269072>, @dexonsmith wrote:
> In D142318#4269070 <https://reviews.llvm.org/D142318#4269070>, @dexonsmith wrote:
>
>> In D142318#4268765 <https://reviews.llvm.org/D142318#4268765>, @MaskRay wrote:
>>
>>> In D142318#4268729 <https://reviews.llvm.org/D142318#4268729>, @avl wrote:
>>>
>>>> so far I suggest to implement safety check as a separate patch. After having a good solution for this.
>>>
>>> Looks good to me.
>>
>> I think if we don't add the check now it's unlikely to happen later.
>
> (Although I do think an independent patch makes sense so it can be reverted independently if it causes trouble.)
I am OK to do that separate patch right after the current patch. Just do not have a good idea for this at the moment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142318/new/
https://reviews.llvm.org/D142318
More information about the llvm-commits
mailing list