[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 12:23:13 PDT 2023

mstorsjo added a comment.

In D145884#4269286 <https://reviews.llvm.org/D145884#4269286>, @dim wrote:

> `compiler-rt/lib/builtins/CMakeLists.txt` includes `compiler-rt/cmake/Modules/CompilerRTUtils.cmake`, then it calls `load_llvm_config()` (a helper function from `CompilertRTUtils`). `load_llvm_config()` figures out the path to `llvm/cmake`, and as far I understand, loads all kinds of settings from there, including paths to llvm headers, libraries, etc. As part of this, it clearly also descends into the "finding required libraries" parts, as it searches for terminfo, zlib, libxml2, etc.
> However, when building the runtimes, it starts from the top-level `runtimes/CMakeLists.txt`, so it doesn't seem to follow this logic.

Right, but when the build of `compiler-rt/lib/builtins` failed to detect zlib, where does that detection result end up used? I presume that the result of that detection ends up in a cmake cache, but I would presume that that cmake cache is specific for the builtins cmake invocation, not influencing other steps (where `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` shouldn't have any effect).

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list