[PATCH] D147866: ValueTracking: Implement computeKnownFPClass for minnum/maxnum
Joshua Cranmer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 12:13:17 PDT 2023
jcranmer-intel added a comment.
`minnum(0.0, 0.0)` can return `-0.0`, so the handling around positive/negative zero isn't correct. Also DAZ/FTZ mode means the subnormal/zero return bits are going to be off.
It's possible to get cleverer about bounds on the minimum and maximum values (e.g., all negative values on one operand and all positive values on the other, we know it must be all positive values), but I don't think that belongs as part of this analysis.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147866/new/
https://reviews.llvm.org/D147866
More information about the llvm-commits
mailing list