[PATCH] D148353: [StringView] remove ctor incompatible with std::string_view

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 10:54:54 PDT 2023


nickdesaulniers added inline comments.


================
Comment at: llvm/include/llvm/Demangle/Utility.h:67
 
-    return operator+=(StringView(TempPtr, Temp.data() + Temp.size()));
   }
----------------
nickdesaulniers wrote:
> This is the change that's breaking the tests...
probably should be `Temp.data() + Temp.size() - TempPtr`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148353/new/

https://reviews.llvm.org/D148353



More information about the llvm-commits mailing list