[PATCH] D147980: Emit unwind information in .debug_frame section when .cfi_sections .debug_frame intrinsic is used

Fri Apr 14 10:50:13 PDT 2023

aprantl added inline comments.

================
Comment at: llvm/test/DebugInfo/AArch64/debugframeinfo.s:6
+# CHECK-EMPTY: 
+# CHECK-NEXT: 00000000 00000014 ffffffff CIE
+# CHECK-NEXT: Format:                DWARF32
----------------
You only want top test that some debug_frame contents is emitted, right?
Assuming that there is another test that already tests whether we are emitting .debug_frame correctly, it should be sufficient to test for a nonempty .debug_frame section here.
All the hardcoded offsets and numbers here are not relevant to you patch and I'm slightly worried that they would change frequently with other unrelated compiler changes?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147980/new/

https://reviews.llvm.org/D147980