[PATCH] D148353: [StringView] remove ctor incompatible with std::string_view

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:2483
+    size_t n = std::distance(First, Last);
+    if (StringView(First, n).startsWith(S)) {
       First += S.size();
----------------
`size_t n = std::distance(First, Last);` can be removed.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:3477
+  size_t n = std::distance(Tmp, First);
+  return StringView(Tmp, n);
 }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148353/new/

https://reviews.llvm.org/D148353