[PATCH] D148348: [StringView] remove dropFront

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:1587
+      assert(sizeof("basic_") - 1 <= SV.size());
+      SV = SV.substr(sizeof("basic_") - 1);
     }
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > anywhere we assign the result back to the string view object we should probably use StringView::remove_prefix instead.
> Nevermind; there is no StringView::remove_prefix. These can be changed to std::string_view::remove_prefix after conversion.
ah @Maskray added that in 3ece37b3fa2c14157ad02967b867570c6a0c08e8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148348/new/

https://reviews.llvm.org/D148348