[PATCH] D148353: [StringView] remove ctor incompatible with std::string_view

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 14 09:58:48 PDT 2023


nickdesaulniers added inline comments.


================
Comment at: llvm/include/llvm/Demangle/StringView.h:57-62
   StringView dropFront(size_t N = 1) const {
     if (N >= size())
       N = size();
-    return StringView(First + N, Last);
+    size_t n = std::distance(First + N, Last);
+    return StringView(First + N, n);
   }
----------------
Nevermind this change and the addition of iterator. I'll remove that once I rebase on top of D148348.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148353/new/

https://reviews.llvm.org/D148353



More information about the llvm-commits mailing list