[PATCH] D148347: [AArch64] Handle vector with two different values
JinGu Kang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 09:54:49 PDT 2023
jaykang10 added a comment.
In D148347#4268664 <https://reviews.llvm.org/D148347#4268664>, @dmgreen wrote:
> Could you add some extra test cases too? For example for the foo case in the summary and for case that are close-but-not-correct, like `BUILD_VECTOR t23, t23, t23, t23, t23, t23, t23, t24, t24, t24, t24, t24, t24, t24, t24, t23`. You should be able to construct tests with a bunch of insertelement's.
Ah! You are right!
It looks the condition does not cover all cases. Let me update the code and add the tests next week.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148347/new/
https://reviews.llvm.org/D148347
More information about the llvm-commits
mailing list