[PATCH] D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole
Amy Kwan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 08:43:30 PDT 2023
amyk added a comment.
Realized I had another unsubmitted comment. I looked again and I do not have any other comments/questions for now aside from the ones that the others have asked about.
================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1722
else {
// We finally eliminate compare instruction in MBB2.
BI2->getOperand(1).setReg(BI1->getOperand(1).getReg());
----------------
Why do we not need to add `addRegToUpdate()` here when we finally eliminate the compare instruction?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133103/new/
https://reviews.llvm.org/D133103
More information about the llvm-commits
mailing list