[PATCH] D148116: [Analysis] Remove DA & LegacyDA

Fri Apr 14 03:49:26 PDT 2023

sameerds added inline comments.

================
Comment at: llvm/lib/Analysis/SyncDependenceAnalysis.cpp:15
 //
-// The SyncDependenceAnalysis is used in the DivergenceAnalysis to model
+// The SyncDependenceAnalysis is used in the UniformityAnalysis to model
 // control-induced divergence in phi nodes.
----------------
foad wrote:
> Pierre-vh wrote:
> > sameerds wrote:
> > > foad wrote:
> > > > I don't think this is true. I think UA uses its own reimplementation of SDA, so this implementation could be removed.
> > > Yeah, nice catch!
> > It's a different analysis so if we remove it, I'd rather make a different patch if that's okay.
> > Do I just remove this sentence instead?
> Sure, remove it or change "is" to "was"...
It's not useful on its own. It's not even an LLVM "Analysis" per se, and it was committed along with DA. It's just a CPP file that contains code that does not need to be in the main DA. I think it should entirely removed with DA.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148116/new/

https://reviews.llvm.org/D148116