[PATCH] D147652: [symbolizer] Check existence of input file in GNU mode

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D147652#4267555 <https://reviews.llvm.org/D147652#4267555>, @sepavloff wrote:

> In D147652#4257424 <https://reviews.llvm.org/D147652#4257424>, @jhenderson wrote:
>
>> 
>
> It looks like llvm-symbolizer also should check input file existence early. It need a separate patch, maybe someone uses such unusual mode.

Right, my points above were all intended to be separate patches (potentially).

> When llvm-symbolizer check existence of binary file, it creates its representation in memory. Even if the file then disappears or is changed, that does not affect decoding process, with uses the cached representation.

I was thinking the early check could just be a "file exists" check, and not to try to open it until later when it's actually used. That would fit better into how the code currently works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147652/new/

https://reviews.llvm.org/D147652