[PATCH] D146872: [1/11][IR] Permit load/store/alloca for struct of the same scalable vector type
Yueh-Ting (eop) Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 00:09:34 PDT 2023
eopXD added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp:160
+ (isa<StructType>(Ty) &&
+ cast<StructType>(Ty)->containsScalableVectorType())) {
MF->getFrameInfo().setStackID(FrameIndex,
----------------
nikic wrote:
> Use `isScalableTy()`?
Changing this to checking `Ty->isScalableTy()` results in changes the code generation of `llvm/test/CodeGen/AArch64/sme-aarch64-svcount.ll`. The change makes sense to me, but the code generation is worse here, @sdesmalen may you confirm if this is reasonable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146872/new/
https://reviews.llvm.org/D146872
More information about the llvm-commits
mailing list