[PATCH] D145208: [COFF] Add MC support for emitting IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY symbols

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 14:21:33 PDT 2023


efriedma updated this revision to Diff 513359.
efriedma added a comment.

Update to fix the addrsig crash.

If an alias points to a weak symbol (which is not itself an alias), the alias is referring to the address of the definition, not the symbol itself.  Make sure MCExpr::findAssociatedFragment continues to handle that case correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145208/new/

https://reviews.llvm.org/D145208

Files:
  llvm/include/llvm/MC/MCDirectives.h
  llvm/include/llvm/MC/MCSymbol.h
  llvm/include/llvm/MC/MCSymbolCOFF.h
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCExpr.cpp
  llvm/lib/MC/MCMachOStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/COFFAsmParser.cpp
  llvm/lib/MC/MCWinCOFFStreamer.cpp
  llvm/lib/MC/WinCOFFObjectWriter.cpp
  llvm/test/MC/COFF/addrsig.s
  llvm/test/MC/COFF/alias.s
  llvm/test/MC/COFF/weak-anti-dep.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145208.513359.patch
Type: text/x-patch
Size: 11366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230413/ff129c0e/attachment.bin>


More information about the llvm-commits mailing list