[PATCH] D148150: [InstrProf][Temporal] Add weight field to traces

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:252
 
-  Writer.addTemporalProfileTraces({LargeTrace, SmallTrace}, 2);
+  SmallVector Traces = {LargeTrace, SmallTrace};
+  Writer.addTemporalProfileTraces(Traces, 2);
----------------
This broke some builds because of compiler warnings, but I believe it should be fixed by https://reviews.llvm.org/D148259.

https://lab.llvm.org/buildbot/#/builders/57/builds/26047

```
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/ProfileData/InstrProfTest.cpp:252:3: error: 'SmallVector' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
  SmallVector Traces = {LargeTrace, SmallTrace};
  ^
/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/include/llvm/ADT/SmallVector.h:1199:22: note: add a deduction guide to suppress this warning
class LLVM_GSL_OWNER SmallVector : public SmallVectorImpl<T>,
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148150/new/

https://reviews.llvm.org/D148150