[PATCH] D148134: [AArch64] Replace DUP scalar by DUP element

JinGu Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 09:04:54 PDT 2023


jaykang10 abandoned this revision.
jaykang10 added a comment.

In D148134#4265364 <https://reviews.llvm.org/D148134#4265364>, @dmgreen wrote:

> For the i64 neon intrinsics it would be possible to change the representation in DAG combine so that they passed and used a v1i64 node, which might help that case simplify in SDAG. Maybe something similar could be done for UADDLV too.
>
> This way has other advantages with it being shared between SDAG and GlobalISel. And might come up in other cases, like across basic-block boundaries. Can we extend it to all the DUP sizes?

I agree with you.
It could be better to solve this issue on SelectionDAG level.
Let me close this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148134/new/

https://reviews.llvm.org/D148134



More information about the llvm-commits mailing list