[PATCH] D148032: [symbolizer] Change error message if module not found
Serge Pavlov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 13 08:50:51 PDT 2023
sepavloff updated this revision to Diff 513261.
sepavloff added a comment.
Avoid double file name printing
If error message already contains file name, module file should not be
printed, otherwise two file names are printed. It happened in the test
llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test. Function
'printError' is modified to avoid such messages.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148032/new/
https://reviews.llvm.org/D148032
Files:
llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
llvm/test/DebugInfo/Symbolize/ELF/symtab-file2.yaml
llvm/test/DebugInfo/symbolize-missing-file.test
llvm/test/tools/llvm-symbolizer/debuginfod-missing-build-id.test
llvm/test/tools/llvm-symbolizer/output-style-inlined.test
llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148032.513261.patch
Type: text/x-patch
Size: 10256 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230413/b9f819d1/attachment.bin>
More information about the llvm-commits
mailing list