[PATCH] D148239: [AMDGPU] Allow use of TTMP registers in AMDGPUResourceUsageAnalysis

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 08:48:06 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:359
-        } else if (AMDGPU::SReg_64RegClass.contains(Reg)) {
-          assert(!AMDGPU::TTMP_64RegClass.contains(Reg) &&
-                 "trap handler registers should not be used");
----------------
cdevadas wrote:
> Shouldn't we retain the assertion for TTMP reg sizes bigger than 32-bit? 
> We don't have any TTMP tuple usage, I guess.
> 
I just don't see the point of the assertion, for any reg size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148239/new/

https://reviews.llvm.org/D148239



More information about the llvm-commits mailing list