[PATCH] D147931: [ARM] Fix null pointer dereferences in ARMMachObjectWriter::recordRelocation()

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.

Thanks. One minor suggestion but otherwise Sounds OK to me.



================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMMachObjectWriter.cpp:432
+  if (!A) { // constant
+    // FIXME! This is Target.isAbsolute() case. We check !A to ensure that null
+    // pointer isn't dereferenced and suppress static analyzer warnings.
----------------
Can you add `This is Target.isAbsolute() case as we check SymB above. ..`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147931/new/

https://reviews.llvm.org/D147931