[PATCH] D148238: [JITLink][RISCV] Handle R_RISCV_CALL_PLT fixups

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

> So I'm not sure if the current strategy of generating PLT entries based on relocation type is correct.

It is not and never has been (think linking -fPIC code into an executable that calls a defined symbol).

> This [2] suggests basing this on whether the target symbol is preemptable.

Yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148238/new/

https://reviews.llvm.org/D148238